-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reducing the token synchronize weight for existing tokens #2660
base: master
Are you sure you want to change the base?
Reducing the token synchronize weight for existing tokens #2660
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2660 +/- ##
============================================
+ Coverage 55.65% 56.05% +0.39%
+ Complexity 8540 8404 -136
============================================
Files 654 654
Lines 49129 48228 -901
Branches 9817 9647 -170
============================================
- Hits 27343 27034 -309
+ Misses 17853 17328 -525
+ Partials 3933 3866 -67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
.../org/wso2/carbon/identity/oauth2/token/handlers/grant/AbstractAuthorizationGrantHandler.java
Show resolved
Hide resolved
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
7c18cd0
to
04e0daf
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12966718542
PR builder started |
PR builder completed |
bc90af4
to
3d61b76
Compare
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12982245036
Proposed changes in this pull request
The synchronize block at the token issuance path seems to lock read only flow, where issuing existing token. For readonly flow, there is no requirement of a synchronize lock. This refactoring reduces the traffic at the synchronized block.
When should this PR be merged
After approval of the Authorization product team and the product owner.
Follow up actions
PR builder test success and QA approval.