Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing the token synchronize weight for existing tokens #2660

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

indeewari
Copy link
Contributor

@indeewari indeewari commented Jan 6, 2025

Proposed changes in this pull request

The synchronize block at the token issuance path seems to lock read only flow, where issuing existing token. For readonly flow, there is no requirement of a synchronize lock. This refactoring reduces the traffic at the synchronized block.

When should this PR be merged

After approval of the Authorization product team and the product owner.

Follow up actions

PR builder test success and QA approval.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.

Project coverage is 56.05%. Comparing base (4e516a5) to head (aa3e9f5).

Files with missing lines Patch % Lines
...dlers/grant/AbstractAuthorizationGrantHandler.java 53.57% 6 Missing and 7 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2660      +/-   ##
============================================
+ Coverage     55.65%   56.05%   +0.39%     
+ Complexity     8540     8404     -136     
============================================
  Files           654      654              
  Lines         49129    48228     -901     
  Branches       9817     9647     -170     
============================================
- Hits          27343    27034     -309     
+ Misses        17853    17328     -525     
+ Partials       3933     3866      -67     
Flag Coverage Δ
unit 39.55% <53.57%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@indeewari indeewari marked this pull request as ready for review January 8, 2025 08:29
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12685956036

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12685956036
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12686897131

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12686897131
Status: failure

Thumimku
Thumimku previously approved these changes Jan 9, 2025
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12966718542

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12966718542
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12966718542

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12976490937

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12976490937
Status: failure

@indeewari indeewari force-pushed the reduce_token_issue_lock_weight branch from bc90af4 to 3d61b76 Compare January 26, 2025 16:54
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12976595557

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12976595557
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12982245036

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12982245036
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12982245036

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants