Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user info response to return roles without internal domain appended #2674

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Jan 16, 2025

@sadilchamishka sadilchamishka force-pushed the improve-userinfo-response-for-roles branch from e4e88d6 to 2dcb821 Compare January 16, 2025 09:11
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 18.18182% with 18 lines in your changes missing coverage. Please review.

Project coverage is 55.66%. Comparing base (f11275f) to head (49a33b9).

Files with missing lines Patch % Lines
...ty/openidconnect/OpenIDConnectClaimFilterImpl.java 6.66% 13 Missing and 1 partial ⚠️
...dentity/oauth/config/OAuthServerConfiguration.java 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2674      +/-   ##
============================================
- Coverage     55.68%   55.66%   -0.02%     
+ Complexity     8428     8416      -12     
============================================
  Files           632      632              
  Lines         48565    48583      +18     
  Branches       8976     8981       +5     
============================================
+ Hits          27042    27045       +3     
- Misses        17651    17664      +13     
- Partials       3872     3874       +2     
Flag Coverage Δ
unit 38.94% <18.18%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sadilchamishka sadilchamishka force-pushed the improve-userinfo-response-for-roles branch from 49a33b9 to 63e5358 Compare January 16, 2025 10:02
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12810813485

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12810813485
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12810813485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants