Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rule evaluation data provider for pre issue access token flow. #2684

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

malithie
Copy link
Contributor

@malithie malithie commented Jan 22, 2025

Proposed changes in this pull request

Resolves wso2/product-is#22353

This PR supports rule evaluation facility with regard to pre issue access token action.
This implements the rule evaluation data provider contract provided for the rule evaluation service for this particular action type in order to feed data needed to evaluate the rule at the execution.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 82.05128% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.65%. Comparing base (4959016) to head (1444af2).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
...identity/oauth/internal/OAuthServiceComponent.java 0.00% 4 Missing ⚠️
...PreIssueAccessTokenRuleEvaluationDataProvider.java 91.42% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2684      +/-   ##
============================================
- Coverage     56.15%   55.65%   -0.51%     
- Complexity     8401     8524     +123     
============================================
  Files           642      645       +3     
  Lines         47828    49283    +1455     
  Branches       9151     9535     +384     
============================================
+ Hits          26859    27429     +570     
- Misses        17141    17960     +819     
- Partials       3828     3894      +66     
Flag Coverage Δ
unit 39.63% <82.05%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	components/org.wso2.carbon.identity.oauth/pom.xml
#	components/org.wso2.carbon.identity.oauth/src/test/resources/testng.xml
#	pom.xml
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12927511268

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12927511268
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12927511268

@malithie malithie merged commit 12a36db into wso2-extensions:master Jan 23, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement rule evaluation data provider for pre issue access token flow.
3 participants