Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Scope Validation Failure with Custom Scope Validators #2692

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AnjanaSamindraPerera
Copy link

Purpose

With this PR, we introduced the below config to add default scopes.

[oauth]
default_requested_scopes = ["default", "scope1"]

Here we use those config values to resolve scope validation failure with custom scope validators.

Related Issue

wso2/product-is#22234

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 26.31579% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.58%. Comparing base (4e516a5) to head (d61976a).

Files with missing lines Patch % Lines
...dentity/oauth/config/OAuthServerConfiguration.java 41.66% 6 Missing and 1 partial ⚠️
...tity/oauth2/authz/AuthorizationHandlerManager.java 0.00% 7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (26.31%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2692      +/-   ##
============================================
+ Coverage     56.18%   56.58%   +0.40%     
+ Complexity     8636     8502     -134     
============================================
  Files           654      654              
  Lines         49129    48230     -899     
  Branches       9817     9644     -173     
============================================
- Hits          27601    27292     -309     
+ Misses        17586    17068     -518     
+ Partials       3942     3870      -72     
Flag Coverage Δ
unit 39.50% <26.31%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13067931583

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13067931583
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13067931583

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants