Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role properties to the SCIM2 Role response #585

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Add role properties to the SCIM2 Role response #585

merged 1 commit into from
Dec 17, 2024

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Dec 10, 2024 •
edited
Loading

Proposed changes in this pull request

Pending tasks

@ShanChathusanda93 ShanChathusanda93 marked this pull request as ready for review December 11, 2024 05:29
@ShanChathusanda93 ShanChathusanda93 force-pushed the role-prop-scim2-branch branch 4 times, most recently from c3eaa5f to cf2684d Compare December 14, 2024 10:32
@AnuradhaSK
Copy link
Contributor

Update the API docs as well

AnuradhaSK
AnuradhaSK previously approved these changes Dec 16, 2024
View reviewed changes
@ShanChathusanda93 ShanChathusanda93 force-pushed the role-prop-scim2-branch branch 2 times, most recently from 5ab4052 to 7f0bf56 Compare December 16, 2024 14:54
@codecov Codecov
Copy link

codecov bot commented Dec 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.15%. Comparing base (a1892e3) to head (4fb4363).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../identity/scim2/common/impl/SCIMRoleManagerV2.java 88.88% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #585      +/-   ##
============================================
+ Coverage     43.76%   44.15%   +0.38%     
+ Complexity     1019      950      -69     
============================================
  Files            41       41              
  Lines          8988     9006      +18     
  Branches       1924     1928       +4     
============================================
+ Hits           3934     3977      +43     
+ Misses         4189     4153      -36     
- Partials        865      876      +11
Flag Coverage Δ
unit 28.59% <88.88%> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12366987834

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12366987834
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 17, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12366987834

@ShanChathusanda93 ShanChathusanda93 merged commit 93d3372 into wso2-extensions:master Dec 17, 2024
5 checks passed
@ShanChathusanda93 ShanChathusanda93 mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SujanSanjula96 SujanSanjula96 SujanSanjula96 approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@AnuradhaSK AnuradhaSK AnuradhaSK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ShanChathusanda93 @AnuradhaSK @jenkins-is-staging @SujanSanjula96