Fix ADD operation replacing permissions of the role #588
+172
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When performing an ADD operation on a role's permissions via the SCIM2 API, the existing permissions are incorrectly replaced instead of appending the new permissions.
Root Cause
The issue was caused by the
prepareReplacedPermissionLists
method being executed for every patch operation. This method clears the existing permissions, which is appropriate for the REPLACE operation but not for ADD or REMOVE.Solution
The fix ensures that
prepareReplacedPermissionLists
is only executed for the REPLACE operation, preventing unintended clearing of permissions during ADD or REMOVE operations.Added unit tests scenarios to cover the permission update operations
Issue
wso2/product-is#21628