Improve applications list performance

[mxm-tr]

Proposed changes in this pull request

Fix for

• Listing service providers slow with OpenLDAP roles  product-is#15168
• Querying getRoleListOfUser(userName) for each application for the same user product-is#4678
• Querying getRoleListOfUser(userName) for each application for the same user #2114

Instead of performing a call to the User store for each Application role, it is performed once.
On our installation it reduced the loading time of the Service Providers list by a large factor (x1000), as the user store we are using had large amount of application roles configured.

When should this PR be merged

ASAP

Checklist (for reviewing)

General

• Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
• Is the PR labeled correctly?

Functionality

• Are all requirements met? Compare implemented functionality with the requirements specification.
• Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

• Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
• Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
• Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

• Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
• If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
• If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

• Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
• Are all UI and API inputs run through forms or serializers?
• Are all external inputs validated and sanitized appropriately?
• Does all branching logic have a default case?
• Does this solution handle outliers and edge cases gracefully?
• Are all external communications secured and restricted to SSL?

Documentation

• Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.
• Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented.
• Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

[CLAassistant]

All committers have signed the CLA.

[sadilchamishka]

This PR is initiated as a fix for the original issue of executing the getRoleListOfUser((username) method repeatedly.

• Fix SP load issue when authenticated user is from LDAP user store #4394

[sadilchamishka]

Suggested change

	return ApplicationMgtUtil.filterApplicationsForUser(applicationBasicInfos, userName);
	return ApplicationMgtUtil.filterUserAuthorizedApplications(applicationBasicInfos, userName);

[sadilchamishka]

Calling another method from this method without any additional steps doesn't seem fine. Either the new method could have been call from where the getAuthorizedApplicationBasicInfo method was called.

[sadilchamishka]

Why it is required to cast and invoke the getRoleListOfUser method. The results would be same as Line 173.

[sadilchamishka]

If the above comment is valid, there is no point of merging. Also these operations will be costly when there large number of roles assigned for the user.

[sadilchamishka]

Can improve the code using Java streams APIs