Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve action execution core #6262

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Jan 6, 2025

Issue:

With this PR following improvements will be added to the action exection core.

  1. Add INCOMPLETE action invocation status. Eg: In the custom authentication, the external service will be want to redirect user to custom page. There we can utilize this new INCOMPLETE state with REDIRECT operation.

  2. This will bring the Bring following method which execute the action id list to its interface.

    ActionExecutionStatus execute(ActionType actionType, String[] actionIdList,
                                  Map<String, Object> eventContext, String tenantDomain)
            throws ActionExecutionException;

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 72.54902% with 28 lines in your changes missing coverage. Please review.

Project coverage is 46.20%. Comparing base (9148662) to head (0ecb300).
Report is 253 commits behind head on master.

Files with missing lines Patch % Lines
...xecution/util/ActionExecutionDiagnosticLogger.java 0.00% 7 Missing ⚠️
...tion/execution/impl/ActionExecutorServiceImpl.java 85.29% 4 Missing and 1 partial ⚠️
...ntity/action/execution/model/IncompleteStatus.java 58.33% 5 Missing ⚠️
...tion/model/ActionInvocationIncompleteResponse.java 77.77% 2 Missing and 2 partials ⚠️
...on/identity/action/execution/model/Incomplete.java 0.00% 4 Missing ⚠️
...on/execution/ActionExecutionResponseProcessor.java 0.00% 2 Missing ⚠️
...tion/execution/model/ActionInvocationResponse.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6262      +/-   ##
============================================
+ Coverage     45.72%   46.20%   +0.47%     
- Complexity    14065    15015     +950     
============================================
  Files          1633     1675      +42     
  Lines        100705   106905    +6200     
  Branches      17706    18767    +1061     
============================================
+ Hits          46045    49391    +3346     
- Misses        47959    50517    +2558     
- Partials       6701     6997     +296     
Flag Coverage Δ
unit 29.63% <72.54%> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action branch 3 times, most recently from 2cd2670 to 4b0b14d Compare January 9, 2025 13:50
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12701805770

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12701805770
Status: failure

@Thisara-Welmilla Thisara-Welmilla force-pushed the improve-action branch 7 times, most recently from 770a0e3 to 8a19f3c Compare January 17, 2025 06:13
malithie
malithie previously approved these changes Jan 20, 2025
@Thisara-Welmilla
Copy link
Contributor Author

The duplication code in sonar report is from ActionInvocationIncompleteResponse.java, but are false positive.
Bump

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12865697102

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12865697102
Status: failure

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12873709484

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12873709484
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12887152107

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12887152107
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12887152107

@Thisara-Welmilla Thisara-Welmilla merged commit 1615183 into wso2:master Jan 21, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants