Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ResolvedUser class #6297

Merged

Conversation

AfraHussaindeen
Copy link
Contributor

Proposed changes in this pull request

Checklist (for reviewing)

General

  • Is this PR explained thoroughly? All code changes must be accounted for in the PR description.
  • Is the PR labeled correctly?

Functionality

  • Are all requirements met? Compare implemented functionality with the requirements specification.
  • Does the UI work as expected? There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.

Code

  • Do you fully understand the introduced changes to the code? If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.
  • Does the PR introduce any inefficient database requests? Use the debug server to check for duplicate requests.
  • Are all necessary strings marked for translation? All strings that are exposed to users via the UI must be marked for translation.

Tests

  • Are there sufficient test cases? Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.
  • If this is a bug fix, are tests for the issue in place? There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.
  • If this is a new feature or a significant change to an existing feature? has the manual testing spreadsheet been updated with instructions for manual testing?

Security

  • Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • Are all UI and API inputs run through forms or serializers?
  • Are all external inputs validated and sanitized appropriately?
  • Does all branching logic have a default case?
  • Does this solution handle outliers and edge cases gracefully?
  • Are all external communications secured and restricted to SSL?

Documentation

  • Are changes to the UI documented in the platform docs? If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.
  • Are changes to the API documented in the API docs? If this PR introduces new API functionality or changes existing ones, the changes must be documented.
  • Are reusable components documented? If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 45.75%. Comparing base (1297afa) to head (5f56ac2).
Report is 244 commits behind head on master.

Files with missing lines Patch % Lines
...dentity/application/common/model/ResolvedUser.java 0.00% 22 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6297      +/-   ##
============================================
+ Coverage     45.70%   45.75%   +0.04%     
- Complexity    14064    14823     +759     
============================================
  Files          1633     1667      +34     
  Lines        100672   106979    +6307     
  Branches      17698    18848    +1150     
============================================
+ Hits          46014    48945    +2931     
- Misses        47960    51076    +3116     
- Partials       6698     6958     +260     
Flag Coverage Δ
unit 29.33% <0.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AfraHussaindeen AfraHussaindeen changed the title Add userId as an attribute to base User class Introduce ResolvedUser class Jan 19, 2025
@AfraHussaindeen AfraHussaindeen force-pushed the master_self-reg-user-id-support branch from 976e5ed to 046b813 Compare January 19, 2025 13:17
sadilchamishka
sadilchamishka previously approved these changes Jan 20, 2025
PasinduYeshan
PasinduYeshan previously approved these changes Jan 20, 2025
@AfraHussaindeen AfraHussaindeen force-pushed the master_self-reg-user-id-support branch from 046b813 to 36a08cb Compare January 20, 2025 05:25
@AfraHussaindeen AfraHussaindeen force-pushed the master_self-reg-user-id-support branch from 36a08cb to 5f56ac2 Compare January 20, 2025 05:33
@AfraHussaindeen AfraHussaindeen merged commit 06db4ae into wso2:master Jan 20, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose userId in the result HTML page after successful self-registration.
4 participants