-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Default SharedProfileValueResolvingMethod for local claims in Unified Claim Manager #6302
Set Default SharedProfileValueResolvingMethod for local claims in Unified Claim Manager #6302
Conversation
PR builder started |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6302 +/- ##
============================================
+ Coverage 45.91% 46.21% +0.29%
+ Complexity 14481 14448 -33
============================================
Files 1672 1672
Lines 103141 102223 -918
Branches 18010 17879 -131
============================================
- Hits 47360 47240 -120
+ Misses 48970 48212 -758
+ Partials 6811 6771 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder started |
PR builder completed |
PR builder completed |
PR builder started |
PR builder completed |
PR builder started |
Quality Gate passedIssues Measures |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12862569685
Proposed changes in this pull request
For user defined custom claims, there can be cases where SharedProfileValueResolvingMethod claim metadata property is not set.
For system defined claims, there can be cases where system claims were persisted in the DB prior to bringing system claims handled by runtime.
To address the above two cases, relevant default values for SharedProfileValueResolvingMethod property should be set in the unified claim manager service.
Logic is:
Check whether the SharedProfileValueResolvingMethod claim property value is empty for the DB persisted claim.
If yes: