Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the commitTransaction issue. #6405

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Jan 29, 2025

Issue:

This PR will fix the following error occured with mySql DB.
An error occurred while commit transactions. java.sql.SQLException: Can't call commit when autocommit=true

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.03%. Comparing base (d870458) to head (e69e1fc).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6405      +/-   ##
============================================
- Coverage     47.03%   47.03%   -0.01%     
+ Complexity    15163    15154       -9     
============================================
  Files          1742     1742              
  Lines        104929   104928       -1     
  Branches      18854    18854              
============================================
- Hits          49350    49349       -1     
  Misses        48567    48567              
  Partials       7012     7012              
Flag Coverage Δ
unit 30.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13025706121

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13025706121
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13025706121

@malithie malithie merged commit e7c1778 into wso2:master Jan 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants