Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new config to define default scopes #6410

Merged

Conversation

AnjanaSamindraPerera
Copy link
Contributor

Purpose

With this PR, we introduced the below config to add default scopes.

[oauth]
default_requested_scopes = ["default", "scope1"]

Here we use those config values to resolve scope validation failure with custom scope validators.

Related Issue

wso2/product-is#22234

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13067934306

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.04%. Comparing base (9257399) to head (85713bf).
Report is 62 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6410      +/-   ##
============================================
- Coverage     47.05%   47.04%   -0.01%     
+ Complexity    15190    15172      -18     
============================================
  Files          1744     1744              
  Lines        105074   105005      -69     
  Branches      18879    18869      -10     
============================================
- Hits          49441    49402      -39     
+ Misses        48610    48581      -29     
+ Partials       7023     7022       -1     
Flag Coverage Δ
unit 30.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13067934306
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13067934306

@AnjanaSamindraPerera AnjanaSamindraPerera merged commit 1500a47 into wso2:master Feb 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants