-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade bouncycastle version to 1.78.1.wso2v1 #275
Conversation
PR builder started |
PR builder completed |
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11238257034
@@ -177,7 +177,7 @@ private X509Certificate generateKeyPair(KeyStore keyStore) throws KeyStoreMgtExc | |||
KeyPair keyPair = keyPairGenerator.generateKeyPair(); | |||
|
|||
// Common Name and alias for the generated certificate | |||
String commonName = "CN=" + tenantDomain + ", OU=None, O=None L=None, C=None"; | |||
String commonName = "CN=" + tenantDomain + ", OU=None, O=None, L=None, C=None"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you do this change due to any particular error? Trying to understand the relationship with the dependency update and this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following error was encountered after the upgrade while creating the tenant keystore. The change has been made to resolve it.
Caused by: java.lang.IllegalArgumentException: badly formatted directory string
at org.bouncycastle.asn1.x500.style.IETFUtils.nextToken(Unknown Source) ~[bcprov-jdk18on-1.78.1.jar:?]
at org.bouncycastle.asn1.x500.style.IETFUtils.addRDN(Unknown Source) ~[bcprov-jdk18on-1.78.1.jar:?]
at org.bouncycastle.asn1.x500.style.IETFUtils.addRDNs(Unknown Source) ~[bcprov-jdk18on-1.78.1.jar:?]
at org.bouncycastle.asn1.x500.style.IETFUtils.rDNsFromString(Unknown Source) ~[bcprov-jdk18on-1.78.1.jar:?]
at org.bouncycastle.asn1.x500.style.BCStyle.fromString(Unknown Source) ~[bcprov-jdk18on-1.78.1.jar:?]
at org.bouncycastle.asn1.x500.X500Name.<init>(Unknown Source) ~[bcprov-jdk18on-1.78.1.jar:?]
at org.bouncycastle.asn1.x500.X500Name.<init>(Unknown Source) ~[bcprov-jdk18on-1.78.1.jar:?]
at org.wso2.carbon.keystore.mgt.KeyStoreGenerator.generateKeyPair(KeyStoreGenerator.java:172) ~[org.wso2.carbon.tenant.keystore.mgt_4.9.10.jar:?]
... 67 more
Purpose
Related issue: wso2/product-is#21200
Goals
Approach
User stories
Release note
Documentation
Training
Certification
Marketing
Automation tests
Security checks
Samples
Related PRs
Migrations (if applicable)
Test environment
Learning