Add api support to try out loginglow AI feature #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sahandilshan
force-pushed
the
loginflowAI_API
branch
from
94e7c77 to
b5bab1d
Compare
sahandilshan
force-pushed
the
loginflowAI_API
branch
from
85c3582 to
9751286
Compare
...o2.carbon.identity.api.server.application.management.v1/src/main/resources/applications.yaml
Show resolved
Hide resolved
...o2.carbon.identity.api.server.application.management.v1/src/main/resources/applications.yaml
Outdated
Show resolved
Hide resolved
...o2.carbon.identity.api.server.application.management.v1/src/main/resources/applications.yaml
Outdated
Show resolved
Hide resolved
...o2.carbon.identity.api.server.application.management.v1/src/main/resources/applications.yaml
Outdated
Show resolved
Hide resolved
| LoginFlowGenerateRequest: | ||
| type: object | ||
| properties: | ||
| available_authenticators: |
There was a problem hiding this comment.
Be consistent with the existing naming convention. Fix other places in the PR as well.
...o2.carbon.identity.api.server.application.management.v1/src/main/resources/applications.yaml
Outdated
Show resolved
Hide resolved
Comment on lines
+91
to
+96
| public static final String CLAIM_URI_KEY = "claimURI"; | ||
| public static final String DESCRIPTION_KEY = "description"; | ||
| public static final String AUTHENTICATOR_NAME_KEY = "name"; | ||
| public static final String AUTHENTICATOR_IDP_KEY = "idp"; | ||
| public static final String AI_RESPONSE_DATA_KEY = "data"; | ||
| public static final String AI_RESPONSE_STATUS_KEY = "status"; |
There was a problem hiding this comment.
Aren't these constant already available from the core in the framework?
|
|
||
| package org.wso2.carbon.identity.api.server.application.management.common.factory; | ||
|
|
||
| import org.springframework.beans.factory.config.AbstractFactoryBean; |
There was a problem hiding this comment.
We are currently removing the spring dependencies. Check whether refactoring this is needed to remove the spring dependencies.
| @@ -187,6 +195,21 @@ public Response getInboundSAMLConfiguration(String applicationId) { | |||
| return Response.ok(samlSp).build(); | |||
| } | |||
|
|
|||
| @Override | |||
| public Response getLoginFlowResult(String operationId) { | |||
There was a problem hiding this comment.
Method name is not self descriptive.
Better to include a word that gives the meaning that this is for login flow generation
| } | ||
|
|
||
| @Override | ||
| public Response getLoginFlowStatus(String operationId) { |
There was a problem hiding this comment.
Method name is not self descriptive.
Better to include a word that gives the meaning that this is for login flow generation status
...a/org/wso2/carbon/identity/api/server/application/management/v1/core/LoginFlowAIService.java
Outdated
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/api/server/application/management/v1/core/LoginFlowAIService.java
Outdated
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/api/server/application/management/v1/core/LoginFlowAIService.java
Outdated
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/api/server/application/management/v1/core/LoginFlowAIService.java
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/api/server/application/management/v1/core/LoginFlowAIService.java
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/api/server/application/management/v1/core/LoginFlowAIService.java
Outdated
Show resolved
Hide resolved
sahandilshan
force-pushed
the
loginflowAI_API
branch
from
ddf97f9 to
0555308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Related Issue(s)
Related PR(s)
*** NOTE: This PR should be merge after merging above pr with the framework version bump