Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify getActionsByActionType API response #747

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ashanthamara
Copy link
Contributor

@ashanthamara ashanthamara commented Dec 1, 2024

Purpose

This PR will change the getActionsByActionType REST API response to be more simplified as there is a separate endpoint to fetch the complete information of an action by action id.

Previous API Response:

[
    {
        "id": "3********************************a",
        "type": "PRE_ISSUE_ACCESS_TOKEN",
        "name": "Access Token Pre Issue",
        "description": "This is the configuration of pre-action for issuing access token.",
        "status": "ACTIVE",
        "endpoint": {
            "uri": "https://myextension.com/token",
            "authentication": {
                "type": "API_KEY"
            }
        }
    }
]

New API Response:

[
    {
        "id": "6********************************7",
        "type": "PRE_ISSUE_ACCESS_TOKEN",
        "name": "test",
        "description": "This is the configuration of pre-action for issuing access token.",
        "status": "ACTIVE",
        "links": [
            {
                "href": "/api/server/v1/actions/preIssueAccessToken/6ba8f776-72a5-407f-b0ed-7154b8653d77",
                "method": "GET",
                "rel": "self"
            }
        ]
    }
]

Related Issue:

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12106709444

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12106709444
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12107748225

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12107748225
Status: failure

@ashanthamara
Copy link
Contributor Author

Seems like the PR builder is not running on the custom branch. It keeps fetching the changes from the master branch. Due to that reason PR builder is failing.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12112484259

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12112484259
Status: cancelled

@ashanthamara ashanthamara merged commit 2a7336e into wso2:master Dec 2, 2024
4 checks passed
@ashanthamara
Copy link
Contributor Author

We are doing a minor version bump in the identity-api-server with this PR as this incorporates an API change for the GET /actions/{actionType} endpoint.
Not doing a version change as the feature still in beta and not yet exposed by a IS release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants