-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spring Cleanup] Remove Spring Framework Dependency #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThaminduR
reviewed
Jan 24, 2025
...ication.management/org.wso2.carbon.identity.api.server.application.management.common/pom.xml
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 24, 2025
...on/identity/api/server/application/management/common/ApplicationManagementServiceHolder.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 24, 2025
...on/identity/api/server/application/management/common/ApplicationManagementServiceHolder.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 24, 2025
...on/identity/api/server/application/management/common/ApplicationManagementServiceHolder.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 24, 2025
...on/identity/api/server/application/management/common/ApplicationManagementServiceHolder.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 24, 2025
...on/identity/api/server/application/management/common/ApplicationManagementServiceHolder.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 24, 2025
} | ||
return service; | ||
|
||
} catch (NullPointerException e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
ThaminduR
reviewed
Jan 24, 2025
...on/identity/api/server/application/management/common/ApplicationManagementServiceHolder.java
Outdated
Show resolved
Hide resolved
lashinijay
force-pushed
the
master-remove-spring
branch
2 times, most recently
from
January 24, 2025 16:42
116667d
to
01e5a5f
Compare
ThaminduR
previously approved these changes
Jan 24, 2025
lashinijay
force-pushed
the
master-remove-spring
branch
from
January 24, 2025 17:17
01e5a5f
to
ddbc1d9
Compare
lashinijay
force-pushed
the
master-remove-spring
branch
from
January 24, 2025 17:20
ddbc1d9
to
40050d4
Compare
ThaminduR
previously approved these changes
Jan 24, 2025
ThaminduR
previously approved these changes
Jan 24, 2025
ThaminduR
reviewed
Jan 24, 2025
...application.management/org.wso2.carbon.identity.api.server.application.management.v1/pom.xml
Outdated
Show resolved
Hide resolved
lashinijay
commented
Jan 24, 2025
...tion.selfservice/org.wso2.carbon.identity.api.server.organization.selfservice.common/pom.xml
Outdated
Show resolved
Hide resolved
lashinijay
commented
Jan 24, 2025
...nization.selfservice/org.wso2.carbon.identity.api.server.organization.selfservice.v1/pom.xml
Outdated
Show resolved
Hide resolved
lashinijay
commented
Jan 24, 2025
...n.identity.api.server.userstore/org.wso2.carbon.identity.api.server.userstore.common/pom.xml
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 24, 2025
...tion.selfservice/org.wso2.carbon.identity.api.server.organization.selfservice.common/pom.xml
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 24, 2025
...nization.selfservice/org.wso2.carbon.identity.api.server.organization.selfservice.v1/pom.xml
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Jan 24, 2025
...2/carbon/identity/api/server/organization/selfservice/v1/core/SelfServiceMgtServiceTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Thamindu R <[email protected]>
ThaminduR
reviewed
Jan 24, 2025
...n.identity.api.server.userstore/org.wso2.carbon.identity.api.server.userstore.common/pom.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Thamindu R <[email protected]>
ThaminduR
reviewed
Jan 24, 2025
...arbon.identity.api.server.userstore/org.wso2.carbon.identity.api.server.userstore.v1/pom.xml
Outdated
Show resolved
Hide resolved
Co-authored-by: Thamindu R <[email protected]>
Co-authored-by: Thamindu R <[email protected]>
ThaminduR
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Related Issue(s)