Add Session managament API implementation #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature-session-api
pamodaaw
changed the title
pamodaaw
force-pushed
the
feature-session-api
branch
from
6f1d5bc to
358a135
Compare
ashensw
approved these changes
Jul 25, 2019
ayshsandu
reviewed
Jul 25, 2019
...in/java/org/wso2/carbon/identity/rest/api/user/session/v1/core/SessionManagementService.java
Show resolved
Hide resolved
ayshsandu
reviewed
Jul 25, 2019
|
|
||
| } catch (SessionManagementException e) { | ||
| log.error(e.getMessage()); | ||
| handleSessionManagementException(e); |
There was a problem hiding this comment.
return exception from the handleSessionManagementException method and throw from here, then no need return null
ayshsandu
reviewed
Jul 25, 2019
|
|
||
| schemes: | ||
| - https | ||
| # host: is.wso2.com |
There was a problem hiding this comment.
host: localhost:9443
basePath: /api/users/v1
pamodaaw
force-pushed
the
feature-session-api
branch
from
7d0944d to
1900121
Compare
omindu
reviewed
Jul 25, 2019
| @Override | ||
| public String toString() { | ||
|
|
||
| return code + " | " + message; |
There was a problem hiding this comment.
Suggested change
| return code + " | " + message; | |
| return getCode() + " | " + message; |
omindu
reviewed
Jul 25, 2019
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>junit</groupId> |
pamodaaw
force-pushed
the
feature-session-api
branch
from
1900121 to
c89922f
Compare
pamodaaw
force-pushed
the
feature-session-api
branch
from
c89922f to
6c814e7
Compare
This was referenced Jul 26, 2019
janakamarasena
pushed a commit
to janakamarasena/identity-api-user
that referenced
this pull request
Sep 27, 2019
janakamarasena
pushed a commit
to janakamarasena/identity-api-user
that referenced
this pull request
Sep 27, 2019
…velopment iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR will add the session management APIs
Approach
Uses the backend functionalities introduced by wso2/carbon-identity-framework#2288
Fixes wso2/product-is#5769