-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SAML connection ProviderName config name #7302
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7302 +/- ##
=======================================
Coverage 36.04% 36.04%
=======================================
Files 42 42
Lines 899 899
Branches 217 205 -12
=======================================
Hits 324 324
- Misses 529 575 +46
+ Partials 46 0 -46
Flags with carried forward coverage won't be shown. Click here to find out more. |
Changeset is accurate IMO, as in this case, we are renaming a configuration. Therefore connections feature (and also i18n module) should release this update as a major version I think. thoughts @brionmario ? |
Lets go with a We only do major releases in Console & My Account and other apps for product releases ex: IS 7.1.0 |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
Purpose
Update SAML connection ProviderName config name to "samlAuthnRequestProviderName".
Related Issues
Related PRs
Checklist
Security checks