Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SAML connection ProviderName config name #7302

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

AmshikaH
Copy link
Contributor

@AmshikaH AmshikaH commented Jan 13, 2025

Purpose

Update SAML connection ProviderName config name to "samlAuthnRequestProviderName".

Related Issues

Related PRs

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.04%. Comparing base (563925f) to head (9ecf97c).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7302   +/-   ##
=======================================
  Coverage   36.04%   36.04%           
=======================================
  Files          42       42           
  Lines         899      899           
  Branches      217      205   -12     
=======================================
  Hits          324      324           
- Misses        529      575   +46     
+ Partials       46        0   -46     
Flag Coverage Δ
@wso2is/core 36.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

pavinduLakshan
pavinduLakshan previously approved these changes Jan 13, 2025
@pavinduLakshan pavinduLakshan dismissed their stale review January 13, 2025 15:51

incorrect changeset

pavinduLakshan
pavinduLakshan previously approved these changes Jan 13, 2025
@pavinduLakshan
Copy link
Contributor

Changeset is accurate IMO, as in this case, we are renaming a configuration. Therefore connections feature (and also i18n module) should release this update as a major version I think. thoughts @brionmario ?

@brionmario
Copy link
Member

brionmario commented Jan 17, 2025

Changeset is accurate IMO, as in this case, we are renaming a configuration. Therefore connections feature (and also i18n module) should release this update as a major version I think. thoughts @brionmario ?

Lets go with a minor version.
If this gets released as a major, then console also will be bumped as a major (not 100% sure of this and need to verify with the changesets config file).

We only do major releases in Console & My Account and other apps for product releases ex: IS 7.1.0

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@AmshikaH AmshikaH merged commit 73f366f into wso2:master Jan 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants