Make the ui_lang & accepts-cookies preference cookies Secure
#7541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brionmario
changed the title
accepts-cookies cookie Secureui_lang & accepts-cookies preference cookies Secure
| var expires = ""; | ||
| var domain = ";domain=" + URLUtils.getDomain(window.location.href); | ||
|
|
||
| if (days) { | ||
| const date = new Date(); | ||
| date.setTime(date.getTime() + (days*24*60*60*1000)); | ||
| var date = new Date(); |
There was a problem hiding this comment.
Do we still need to avoid const since es6 is widely supported?
| } | ||
|
|
||
| /** | ||
| * Handles language change by setting the `ui_locale` cookie. | ||
| */ | ||
| function setUILocaleCookie(language) { | ||
| var EXPIRY_DAYS = 30; | ||
| setCookie('ui_lang', language, EXPIRY_DAYS); | ||
| setCookie('ui_lang', language, EXPIRY_DAYS, { secure: true }); |
There was a problem hiding this comment.
if we set ui_lang to secure, js logic will fail to read the cookie, won't it?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7541 +/- ##
==========================================
+ Coverage 41.77% 41.85% +0.07%
==========================================
Files 42 42
Lines 936 939 +3
Branches 235 238 +3
==========================================
+ Hits 391 393 +2
- Misses 501 502 +1
Partials 44 44
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request includes several changes aimed at enhancing the security of cookies by making them secure. The changes span across multiple files and involve adding the
Secureattribute to cookies and updating related functions to support additional options for cookies.Security Enhancements:
.changeset/cyan-cheetahs-warn.md: Documented the changes as patch updates for several packages and specified making theui_lang&accepts-cookiespreference cookiesSecure.apps/myaccount/src/components/shared/header.tsx: Updated thesetCookiefunction call to include thesecureoption.apps/myaccount/src/layouts/dashboard.tsx: Updated thesetCookiefunction call to include thesecureoption.identity-apps-core/apps/authentication-portal/src/main/webapp/includes/footer.jsp: Added theSecureattribute to the cookie consent clear function.identity-apps-core/apps/authentication-portal/src/main/webapp/includes/language-switcher.jsp: Modified thesetCookiefunction to accept additional options (httpOnlyandsecure) and updated the function implementation accordingly.identity-apps-core/apps/recovery-portal/src/main/webapp/includes/footer.jsp: Added theSecureattribute to the cookie consent clear function.identity-apps-core/apps/recovery-portal/src/main/webapp/includes/language-switcher.jsp: Modified thesetCookiefunction to accept additional options (httpOnlyandsecure) and updated the function implementation accordingly. [1] [2]identity-apps-core/apps/x509-certificate-authentication-portal/src/main/webapp/includes/footer.jsp: Added theSecureattribute to the cookie consent clear function.identity-apps-core/apps/x509-certificate-authentication-portal/src/main/webapp/includes/language-switcher.jsp: Modified thesetCookiefunction to accept additional options (httpOnlyandsecure) and updated the function implementation accordingly.modules/core/src/utils/__tests__/cookie-storage-utils.test.ts: Added a test case to verify that thesetCookiefunction correctly sets cookies withHttpOnlyandSecureoptions.modules/core/src/utils/storage-utils.ts: Updated thesetCookiefunction inCookieStorageUtilsto accept additional options (httpOnlyandsecure) and updated the function implementation accordingly. [1] [2] [3]modules/react-components/src/components/banner/cookie-consent-banner.tsx: Updated thesetCookiefunction call to include thesecureoption.Related Issues
Related PRs
Checklist
Security checks