Skip to content

Commit

Permalink
Update test id
Browse files Browse the repository at this point in the history
  • Loading branch information
asekawa committed Feb 19, 2024
1 parent 8e309b1 commit 354604e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/ui/constants/login-page-dom-constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export class LoginPageDomConstants {

// TODO: Use data test id's here.
// Tracker: https://github.com/wso2-enterprise/asgardeo-product/issues/999
public static readonly USERNAME_INPUT_DATA_ATTR: string = "usernameUserInput";
public static readonly USERNAME_INPUT_DATA_ATTR: string = "login-page-username-input";
public static readonly PASSWORD_INPUT_DATA_ATTR: string = "login-page-password-input";
public static readonly CONTINUE_BUTTON_DATA_ATTR: string = "identifier-auth-continue-button";
public static readonly SUBMIT_BUTTON_DATA_ATTR: string = "login-page-continue-login-button";
Expand Down
5 changes: 3 additions & 2 deletions src/ui/page-objects/login-page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,9 @@ export class LoginPage {
* Get the data attribute for login page user input field.
* @return {Cypress.Chainable<JQuery<HTMLElement>>}
*/
public getLoginUsernameInputField(): Cypress.Chainable<JQuery<HTMLElement>> {
return cy.get(LoginPageDomConstants.USERNAME_INPUT_DATA_ATTR);
public getLoginUsernameInputField(): Cypress.Chainable<Element> {

return cy.dataTestId(LoginPageDomConstants.USERNAME_INPUT_DATA_ATTR);
}

/**
Expand Down

0 comments on commit 354604e

Please sign in to comment.