Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OAuthAppsWithSameClientIdTestCase #22193

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update OAuthAppsWithSameClientIdTestCase #22193

merged 1 commit into from
Jan 16, 2025

Conversation

madurangasiriwardena
Copy link
Member

@madurangasiriwardena madurangasiriwardena commented Jan 7, 2025 •
edited
Loading

testOAuthApplicationLoginWhenTenantQualifiedUrlsDisabled method had forced this test to be in the group that requires restarts.
But at some point in the past, the method was commented out temporarily, but was never enabled. Based on the recent changes we know that the tenant qualified URLs cannot be disabled in the product. So we can get rid of the commented out code and now there is no requirement to place this test in the group that require restarts.

Hence removed the restart related code and moved to a place in testng.xml that doesn't involve restarts.

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12651650933

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12651650933
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12672640423

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12672723626

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12672640423
Status: cancelled

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12672723626
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12674991105

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12674991105
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12677180082

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12677180082
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12806390118

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12806390118
Status: failure

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12809698945

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12809698945
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12809698945

@UdeshAthukorala UdeshAthukorala merged commit 79353a6 into wso2:master Jan 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@UdeshAthukorala UdeshAthukorala UdeshAthukorala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madurangasiriwardena @jenkins-is-staging @UdeshAthukorala