Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API tests that covers managing actions with rules #22227

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Add API tests that covers managing actions with rules #22227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
96af10c
Refactored and added action rule related success testcases.
malithie Jan 9, 2025
b4af5f0
Add action rule related failure testcases.
malithie Jan 9, 2025
52acec7
Merge branch 'master' into rules-management
malithie Jan 9, 2025
8b11145
Update spi server version.
malithie Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 96 additions & 1 deletion ...o2/identity/integration/test/rest/api/server/action/management/v1/ActionsFailureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,13 @@
import org.testng.annotations.Factory;
import org.testng.annotations.Test;
import org.wso2.carbon.automation.engine.context.TestUserMode;
import org.wso2.identity.integration.test.rest.api.server.action.management.v1.model.ANDRule;
import org.wso2.identity.integration.test.rest.api.server.action.management.v1.model.ActionModel;
import org.wso2.identity.integration.test.rest.api.server.action.management.v1.model.ActionUpdateModel;
import org.wso2.identity.integration.test.rest.api.server.action.management.v1.model.AuthenticationType;
import org.wso2.identity.integration.test.rest.api.server.action.management.v1.model.Endpoint;
import org.wso2.identity.integration.test.rest.api.server.action.management.v1.model.Expression;
import org.wso2.identity.integration.test.rest.api.server.action.management.v1.model.ORRule;

import java.io.IOException;
import java.util.HashMap;
Expand Down Expand Up @@ -155,7 +158,41 @@ public void testCreateActionAfterReachingMaxActionCount() {
.body("description", equalTo("Maximum number of actions per action type is reached."));
}

@Test(dependsOnMethods = {"testCreateActionAfterReachingMaxActionCount"})
@Test(dependsOnMethods = {"testCreateActionWithEmptyEndpointAuthPropertyValues"})
public void testCreateActionWithInvalidRule() {

// Create an action, with an expression with an invalid field name.
ORRule rule = new ORRule()
.condition(ORRule.ConditionEnum.OR)
.addRulesItem(new ANDRule().condition(ANDRule.ConditionEnum.AND)
.addExpressionsItem(new Expression().field("invalid").operator("equals")
.value("855bb864-2839-4bdf-aabd-4cc635b6faba")));

ActionModel action = new ActionModel()
.name(TEST_ACTION_NAME)
.description(TEST_ACTION_DESCRIPTION)
.endpoint(new Endpoint()
.uri(TEST_ENDPOINT_URI)
.authentication(new AuthenticationType()
.type(AuthenticationType.TypeEnum.BASIC)
.properties(new HashMap<String, Object>() {{
put(TEST_USERNAME_AUTH_PROPERTY, TEST_USERNAME_AUTH_PROPERTY_VALUE);
put(TEST_PASSWORD_AUTH_PROPERTY, TEST_PASSWORD_AUTH_PROPERTY_VALUE);
}})))
.rule(rule);

String body = toJSONString(action);
Response responseOfPost = getResponseOfPost(ACTION_MANAGEMENT_API_BASE_PATH +
PRE_ISSUE_ACCESS_TOKEN_PATH, body);
responseOfPost.then()
.log().ifValidationFails()
.assertThat()
.statusCode(HttpStatus.SC_BAD_REQUEST).body("code", equalTo("ACTION-60013"))
.body("message", equalTo("Invalid rule."))
.body("description", equalTo("Rule validation failed: Field invalid is not supported"));
}

@Test(dependsOnMethods = {"testCreateActionWithInvalidRule"})
public void testGetActionByActionIdWithInvalidID() {

Response responseOfGet = getResponseOfGet(ACTION_MANAGEMENT_API_BASE_PATH +
Expand Down Expand Up @@ -198,6 +235,35 @@ public void testUpdateActionWithInvalidID() {
.body("description", equalTo("No Action is configured on the given Action Type and Id."));
}

@Test(dependsOnMethods = {"testUpdateActionWithInvalidID"})
public void testUpdateActionWithInvalidRule() {

String createdActionId = createActionWithRule();

// Update the action, with an expression with an invalid operator.
ORRule rule = new ORRule()
.condition(ORRule.ConditionEnum.OR)
.addRulesItem(new ANDRule().condition(ANDRule.ConditionEnum.AND)
.addExpressionsItem(new Expression().field("application").operator("invalid")
.value("855bb864-2839-4bdf-aabd-4cc635b6faba")));

ActionUpdateModel actionUpdateModel = new ActionUpdateModel().rule(rule);

String body = toJSONString(actionUpdateModel);
Response responseOfPatch = getResponseOfPatch(ACTION_MANAGEMENT_API_BASE_PATH +
PRE_ISSUE_ACCESS_TOKEN_PATH + "/" + createdActionId, body);
responseOfPatch.then()
.log().ifValidationFails()
.assertThat()
.statusCode(HttpStatus.SC_BAD_REQUEST).body("code", equalTo("ACTION-60013"))
.body("message", equalTo("Invalid rule."))
.body("description",
equalTo("Rule validation failed: Operator invalid is not supported for field application"));

// Delete, created action.
deleteAction(PRE_ISSUE_ACCESS_TOKEN_PATH, createdActionId);
}

@Test(dependsOnMethods = {"testUpdateActionWithInvalidID"})
public void testActivateActionWithInvalidID() {

Expand Down Expand Up @@ -251,4 +317,33 @@ private String createAction(String actionTypePath) {

return responseOfPost.getBody().jsonPath().getString("id");
}

private String createActionWithRule() {

ORRule rule = new ORRule()
.condition(ORRule.ConditionEnum.OR)
.addRulesItem(new ANDRule().condition(ANDRule.ConditionEnum.AND)
.addExpressionsItem(new Expression().field("application").operator("equals")
.value("855bb864-2839-4bdf-aabd-4cc635b6faba")));

ActionModel action = new ActionModel()
.name(TEST_ACTION_NAME)
.description(TEST_ACTION_DESCRIPTION)
.endpoint(new Endpoint()
.uri(TEST_ENDPOINT_URI)
.authentication(new AuthenticationType()
.type(AuthenticationType.TypeEnum.BASIC)
.properties(new HashMap<String, Object>() {{
put(TEST_USERNAME_AUTH_PROPERTY, TEST_USERNAME_AUTH_PROPERTY_VALUE);
put(TEST_PASSWORD_AUTH_PROPERTY, TEST_PASSWORD_AUTH_PROPERTY_VALUE);
}})))
.rule(rule);

String body = toJSONString(action);
Response responseOfPost = getResponseOfPost(ACTION_MANAGEMENT_API_BASE_PATH +
PRE_ISSUE_ACCESS_TOKEN_PATH, body);
responseOfPost.then().assertThat().statusCode(HttpStatus.SC_CREATED);

return responseOfPost.getBody().jsonPath().getString("id");
}
}
Loading