Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp auth code test case by calling AS directly #22230

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

Thumimku
Copy link
Contributor

@Thumimku Thumimku commented Jan 10, 2025

Current flow in test case has some limitations.

  • depend on outdated playground app
  • by default consent is skipped, having unnecessary method to approve consent

This PR address this limitation and fix intermittent failure.

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/12703552183

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12703552183
Status: success

Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12703552183

@Thumimku Thumimku merged commit 31468d9 into wso2:master Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants