-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keepalive configs as templated strings and modify their values #3624
Conversation
keepalive_probes: 3 | ||
keepalive_time: 300 | ||
keepalive_interval: 30 | ||
keepalive_probes: '${KEEPALIVE_PROBES}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we prefix ADAPTER to make these config more specific?
keepalive_probes: '${KEEPALIVE_PROBES}' | |
keepalive_probes: '${ADAPTER_KEEPALIVE_PROBES}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can keep this as it is and use it in all places. Hence +1
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.12 |
[succeeded] : dev-deployment-v2 : 20241217.12 |
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241217.12 |
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241217.13 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.13 |
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241217.14 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.14 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.15 |
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241217.15 |
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241217.16 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.16 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.17 |
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241217.17 |
[failed] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241217.18 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.18 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.19 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.20 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.21 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.22 |
1 similar comment
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.22 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.23 |
[failed] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241217.24 |
[] : dev-deployment-v2 : 20241218.2 |
[] Dataplane(NorthEU) cluster : dev-deployment-v2 : 20241218.2 |
[] Dataplane(EastUS) cluster : dev-deployment-v2 : 20241218.2 |
[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241219.1 |
[succeeded] Controlplane cluster : prod-deployment-v2 : 20241219.1 |
[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20241219.1 |
[failed] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20241219.1 |
[succeeded] Controlplane cluster : prod-deployment-v2 : 20241219.1 |
[succeeded] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20241219.1 |
[failed] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20241219.1 |
[succeeded] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241219.1 |
[] Dataplane(EastUS) cluster : prod-deployment-v2 : 20241219.2 |
[] Dataplane(NorthEU) cluster : prod-deployment-v2 : 20241219.2 |
[] Dataplane(CDP2-WU2) cluster : prod-deployment-v2 : 20241219.2 |
[] Controlplane cluster : prod-deployment-v2 : 20241219.2 |
Purpose
Lower the 5-minute interval to check for liveness of adapter after establishing a connection to it to 1 minute. This would allow for faster detection when the local adapter goes down and enable faster switching to another replica. Additionally, by making these values dynamically configurable, we can adjust them as and when needed in the future.
Issues
Fixes https://github.com/wso2-enterprise/choreo/issues/32445
Automation tests
Tested environments
Not Tested
Maintainers: Check before merge