Cache inline synapse expressions #2287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/core/src/main/java/org/apache/synapse/util/InlineExpressionUtil.java
Show resolved
Hide resolved
| if (expression == null) { | ||
| expression = new SynapseExpression(placeholder); | ||
| expressionCache.put(placeholder, expression); | ||
| } | ||
| String replacement = expression.stringValueOf(synCtx); |
There was a problem hiding this comment.
shall we calculate replacement values for the entire cached map at once. If we have the same expression used in several places, we don't have to evaluate again.
There was a problem hiding this comment.
Fixed with c699634 for the Payload factory. Logging the same expression multiple times in the same log is a rare cases. Hence skipped evaluated value caching in log mediator
SanojPunchihewa
force-pushed
the
inline-exp-cache
branch
from
e5990aa to
7edea4a
Compare
GDLMadushanka
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Cache inline synapse expressions
Fixes: wso2/product-micro-integrator#3873
Fixes: wso2/product-micro-integrator#3878