Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 5 Renderer #100

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Bootstrap 5 Renderer #100

merged 7 commits into from
Mar 12, 2024

Conversation

coolacid
Copy link
Contributor

This builds on #84

Reverted all the flag bits, found the correct way todo this. Just adding the bootstrap5 class, and passing that to the template renderer does exactly what is needed.

Moved, the example into different directories, this keeps the simple example unchanged, but adds a Bootstrap5 example version.

@qs5779
Copy link
Contributor

qs5779 commented Mar 11, 2024

My day just ended, I will look at this first thing tomorrow.

@coolacid
Copy link
Contributor Author

I appreciate your time.

Copy link
Contributor

@qs5779 qs5779 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goodl

@qs5779 qs5779 merged commit 900b6c8 into wtfo-guru:main Mar 12, 2024
@qs5779
Copy link
Contributor

qs5779 commented Mar 12, 2024

Published v0.7.2 at https://test.pypi.org/project/flask-nav3/ please verify all is well.

@coolacid
Copy link
Contributor Author

Confirmed with my application I'm working on. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants