Add enhanced filter to autocomplete #221
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new field,
enhanced_filter
toAutoCompleteBuilder
.enhanced_filter
takes the following arguments:has_column
- Name of the required columnfilter
- Predicate used for filteringIff in the table to be filtered, there exists a column
<has_column>
, the filter will be executed.Consider the following example:
Let's say the table Food is populated with a green apple and a red pepper.
If I want to filter for green food, I would do
value_filter: {color_id: <green_id>}
.This works as long as a user doesn't try to filter this by
type =
. In that case,value_filter
will be applied to the table Type, which doesn't have acolor_id
column, causing an exception.enhanced_filter
prevents this by first checking for the existence of the required column before filtering.