Improve search queries based on datetime #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamlazik1
force-pushed
the
fix-time-search
branch
2 times, most recently
from
ee12200 to
21d2a9b
Compare
The current implementation causes issues such as: 1. When searching for timestamps greater than the given value and minutes and seconds are omitted the value, it returns only timestamps greater than value + 1 hour. 2. When searching for timestamps greater than the given value and only month is provided as the smallest time unit, it excludes only timestamps from the first day of the month in the results but includes rest of month. Based on the logic implemented here this should not happen but instead the whole month should be excluded from the search results, i.e. '> January 2024' should exclude all January timestamps. Same problems occur when searching with `<=`. This PR aims to fix these issues.
adamlazik1
force-pushed
the
fix-time-search
branch
from
21d2a9b to
836f952
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation causes issues such as:
When searching for timestamps greater than the given value and
minutes and seconds are omitted the value, it returns only timestamps
greater than value + 1 hour.
When searching for timestamps greater than the given value and only
month is provided as the smallest time unit, it excludes only timestamps
from the first day of the month in the results but includes rest of
month. Based on the logic implemented here this should not happen but
instead the whole month should be excluded from the search results, i.e.
'> January 2024' should exclude all January timestamps.
Same problems occur when searching with
<=.This PR aims to fix these issues.