feat: scale autoplay rate to chart size, expose var AUTOPLAY_RATE to …

…users (#580)
xability · Oct 15, 2024 · ebb19a9 · ebb19a9
1 parent 4742cb4
commit ebb19a9
Show file tree

Hide file tree

Showing 9 changed files with 546 additions and 559 deletions.
diff --git a/galleries/bar_plot.html b/galleries/bar_plot.html
@@ -6,7 +6,6 @@
     <meta charset="utf-8" />
     <!-- <link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-GLhlTQ8iRABdZLl6O3oVMWSktQOp6b7In1Zl3/Jr59b6EGGoI1aFkw7cmDA6j6gD" crossorigin="anonymous"> -->
     <link rel="stylesheet" href="../src/css/styles.css" type="text/css" />
-    <script src="/dist/maidr.min.js"></script>
   </head>
 
   <body>
@@ -1147,7 +1146,6 @@
         data: [1610, 4906, 12082, 13791, 21551],
       };
     </script>
-    <!--
     <script src="../src/js/constants.js"></script>
     <script src="../src/js/audio.js"></script>
     <script src="../src/js/display.js"></script>
@@ -1157,5 +1155,5 @@
     <script src="../src/js/scatterplot.js"></script>
     <script src="../src/js/controls.js"></script>
     <script src="../src/js/init.js"></script>
-  --></body>
+  </body>
 </html>
diff --git a/src/js/barplot.js b/src/js/barplot.js
@@ -166,9 +166,8 @@ class BarChart {
       }
     }
     constants.maxX = this.columnLabels.length;
-    constants.autoPlayRate = Math.min(
-      Math.ceil(constants.AUTOPLAY_DURATION / (constants.maxX + 1)),
-      constants.MAX_SPEED
+    constants.autoPlayRate = Math.ceil(
+      constants.AUTOPLAY_DURATION / this.plotData.length
     );
     constants.DEFAULT_SPEED = constants.autoPlayRate;
     if (constants.autoPlayRate < constants.MIN_SPEED) {

diff --git a/src/js/boxplot.js b/src/js/boxplot.js
@@ -177,10 +177,7 @@ class BoxPlot {
       constants.minY = 0;
       constants.maxY = this.plotData.length - 1;
     }
-    constants.autoPlayRate = Math.min(
-      Math.ceil(constants.AUTOPLAY_DURATION / this.plotData.length),
-      constants.MAX_SPEED
-    );
+    constants.autoPlayRate = Math.ceil(constants.AUTOPLAY_DURATION / 7);
     constants.DEFAULT_SPEED = constants.autoPlayRate;
     if (constants.autoPlayRate < constants.MIN_SPEED) {
       constants.MIN_SPEED = constants.autoPlayRate;