Apply suggestions from code review

xataio · Aug 2, 2024 · 6fb7d73 · 6fb7d73
1 parent 38786da
commit 6fb7d73
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/.github/workflows/release-cli-assets.yml b/.github/workflows/release-cli-assets.yml
@@ -107,11 +107,7 @@ jobs:
           XATA_WINDOWS_CERTIFICATE_KEY: ${{ secrets.WINDOWS_CERTIFICATE_KEY }}
         if: matrix.os == 'ubuntu-latest'
         run: |
-          # create variables
-          CERTIFICATE_PATH=~/xata.key
-
-          echo -n `$XATA_WINDOWS_CERTIFICATE_KEY` >> $CERTIFICATE_PATH
-          echo $CERTIFICATE_PATH
+          echo -n `$XATA_WINDOWS_CERTIFICATE_KEY` >> ~/xata.key
 
       - name: Configure AWS Credentials for production
         uses: aws-actions/configure-aws-credentials@v4
@@ -131,7 +127,7 @@ jobs:
         env:
           MATRIX_OS: ${{ matrix.os }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          XATA_WINDOWS_SIGNING_PASS: "'${{ secrets.WINDOWS_CERTIFICATE_SECRET }}'"
+          XATA_WINDOWS_SIGNING_PASS: ${{ secrets.WINDOWS_CERTIFICATE_SECRET }}
 
       - name: Debian cert
         if: matrix.os == 'ubuntu-latest'