-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add total count to search responses #1232
Conversation
🦋 Changeset detectedLatest commit: ffcf6cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Your pull request has been published to npm. You can install @xata.io/client by running:
Other packages are published like this:
To test the CLI, run:
|
I'll fully review it on Thursday when I'm back. Only concern is in |
@SferaDev Yeah that's a good point, I've now nested under |
This PR adds the
totalCount
field to search responses (search
,search.byTable
,search.all
, andvectorSearch
)It contains breaking changes to the search APIs as the response is no longer an array, but an object, for example:
Note that:
search.byTable
returns a records object rather than an records array. Each table name is a key pointing to an array, for example:Resolves #1081