Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CLI assets to release #1447

Merged
merged 18 commits into from
Apr 30, 2024
Merged

feat: add CLI assets to release #1447

merged 18 commits into from
Apr 30, 2024

Conversation

eemmiillyy
Copy link
Contributor

@eemmiillyy eemmiillyy commented Apr 24, 2024

Part of #1393

Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: f15ba6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 24, 2024

Your pull request has been published to npm.

You can install @xata.io/client by running:

npm install @xata.io/[email protected]

Other packages are published like this:

npm install @xata.io/[email protected]

To test the CLI, run:

npx @xata.io/[email protected]

Copy link
Contributor

github-actions bot commented Apr 24, 2024

size-limit report 📦

Path Size
packages/client/dist/index.mjs 21.08 KB (0%)
packages/client/dist/index.cjs 22.3 KB (0%)
packages/codegen/dist/index.mjs 1.99 MB (0%)
packages/codegen/dist/index.cjs 1.99 MB (0%)

@eemmiillyy eemmiillyy marked this pull request as ready for review April 30, 2024 08:03
@eemmiillyy eemmiillyy requested a review from a team as a code owner April 30, 2024 08:03
cli/package.json Outdated Show resolved Hide resolved
const PATH_TO_IMPORTER = process.cwd() + '/packages/importer';
const PATH_TO_PGROLL = process.cwd() + '/packages/pgroll';

const base = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a type, can be in a follow-up

Comment on lines 68 to 72

release-cli-assets:
needs: release
uses: ./.github/workflows/release-cli-assets.yml
secrets: inherit
Copy link
Member

@SferaDev SferaDev Apr 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a step after Publish to npm and runs conditionally only if publish was successful.

https://github.com/changesets/action?tab=readme-ov-file#outputs

Comment on lines +62 to +65
'@xata.io/client': clientVersion ?? 'latest',
'@xata.io/codegen': codegenVersion ?? 'latest',
'@xata.io/importer': importerVersion ?? 'latest',
'@xata.io/pgroll': pgrollVersion ?? 'latest'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions shouldn't be undefined? Maybe error if that happens?

Comment on lines +73 to +74
execFile('rm', ['-rf', `${PATH_TO_CLI}/npm-shrinkwrap.json`]);
execFile('touch', [`${PATH_TO_CLI}/npm-shrinkwrap.json`]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment

@SferaDev SferaDev merged commit 75739d0 into main Apr 30, 2024
2 checks passed
@SferaDev SferaDev deleted the feat/release-assets branch April 30, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants