-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CLI assets to release #1447
Conversation
|
Your pull request has been published to npm. You can install @xata.io/client by running:
Other packages are published like this:
To test the CLI, run:
|
size-limit report 📦
|
const PATH_TO_IMPORTER = process.cwd() + '/packages/importer'; | ||
const PATH_TO_PGROLL = process.cwd() + '/packages/pgroll'; | ||
|
||
const base = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can add a type, can be in a follow-up
.github/workflows/release.yml
Outdated
|
||
release-cli-assets: | ||
needs: release | ||
uses: ./.github/workflows/release-cli-assets.yml | ||
secrets: inherit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a step after Publish to npm
and runs conditionally only if publish was successful.
https://github.com/changesets/action?tab=readme-ov-file#outputs
'@xata.io/client': clientVersion ?? 'latest', | ||
'@xata.io/codegen': codegenVersion ?? 'latest', | ||
'@xata.io/importer': importerVersion ?? 'latest', | ||
'@xata.io/pgroll': pgrollVersion ?? 'latest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versions shouldn't be undefined? Maybe error if that happens?
execFile('rm', ['-rf', `${PATH_TO_CLI}/npm-shrinkwrap.json`]); | ||
execFile('touch', [`${PATH_TO_CLI}/npm-shrinkwrap.json`]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment
Part of #1393