-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document fetchOptions #206
Conversation
Check out the preview at https://xata-docs-pr-206.vercel.app |
Co-authored-by: joan-ing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
fix revalidate period
Let's not merge this yet. While fetchOptions does its part from the SDK side, we haven't been able to verify the cache actually works with these. |
|
||
The Xata SDK supports the `fetchOptions` parameter for passing options to fetch. | ||
|
||
This parameter can be used to configure cache revalidation at a timed interval: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make this more clear it's only for Next.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add clarifications once we have findings from xataio/client-ts#1311 as it doesn't seem to actually work as documented, maybe there's more steps needed in Next.js.
I will close this PR until we figure out additional guidelines required from xataio/client-ts#1311 , as merging as-is is unlikely to help users. |
Closes #200