Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for summarize and aggregate docs #350

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fixes for summarize and aggregate docs #350

merged 1 commit into from
Jun 26, 2024

Conversation

kostasb
Copy link
Contributor

@kostasb kostasb commented Jun 26, 2024

  • Fix incorrect call syntax for columns in summarize snippets
  • Rephrase suggestion to using Aggregate as a "no result limits" endpoint as it is not true for every call. For example, a common case for users trying out aggregate is the 1000 result buckets of Summarize, which still applies in Aggregate's top values. This avoids setting expectations that can't be met in every case.

@kostasb kostasb requested review from snide, SferaDev and philkra June 26, 2024 14:19
@xata-bot
Copy link

xata-bot commented Jun 26, 2024

Check out the preview at https://xata-docs-pr-350.vercel.app

Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kostasb kostasb added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 6febfc6 Jun 26, 2024
5 checks passed
@kostasb kostasb deleted the agg-fixes branch June 26, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants