Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New statements added to permissions matrix, permissions updated #360

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

deverts
Copy link
Member

@deverts deverts commented Jul 5, 2024

@deverts deverts requested review from amvieites and kvch July 5, 2024 14:35
@xata-bot
Copy link

xata-bot commented Jul 5, 2024

Check out the preview at https://xata-docs-pr-360.vercel.app

@@ -138,66 +138,88 @@ Xata offers Postgres in a variety of [pricing formats](/pricing). Shared cluster

The table below provides full granularity over specific statements.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is not very helpful 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this is not ideal... I think since I added a long statement name, the linter then extended all of the first column for every row

@deverts deverts enabled auto-merge July 10, 2024 12:37
@deverts
Copy link
Member Author

deverts commented Jul 10, 2024

@amvieites @kvch - could i get a 👍/👎 so I can get this one moving?

Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deverts deverts added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 3dd8512 Jul 10, 2024
5 checks passed
@deverts deverts deleted the 4837-new-statements-permissions branch July 10, 2024 12:39
github-merge-queue bot pushed a commit that referenced this pull request Jul 10, 2024
depends on #360 

Not sure if this is what we want, but it made it easier for me to find
what I was looking for. Consider it: we can merge if we like it, or
close otherwise.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants