Add support for foreign key constraints in create_table operation
#597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agedemenli
reviewed
Jan 20, 2025
internal/jsonschema/testdata/create-table-14-invalid-fk-missing-referenced-table.txtar
Outdated
Show resolved
Hide resolved
internal/jsonschema/testdata/create-table-15-invalid-fk-missing-columns.txtar
Outdated
Show resolved
Hide resolved
kvch
commented
Jan 22, 2025
pkg/migrations/op_common_test.go
Outdated
| @@ -40,6 +44,14 @@ func ExecuteTests(t *testing.T, tests TestCases, opts ...roll.Option) { | |||
| testSchema := testutils.TestSchema() | |||
|
|
|||
| for _, tt := range tests { | |||
| if tt.minPgMajorVersion != 0 && os.Getenv("POSTGRES_VERSION") != "" { | |||
There was a problem hiding this comment.
I had to add this because setting a column list for ON DELETE actions was released in pg15.
pkg/migrations/op_common_test.go
Outdated
| @@ -40,6 +44,14 @@ func ExecuteTests(t *testing.T, tests TestCases, opts ...roll.Option) { | |||
| testSchema := testutils.TestSchema() | |||
|
|
|||
| for _, tt := range tests { | |||
| if tt.minPgMajorVersion != 0 && os.Getenv("POSTGRES_VERSION") != "" { | |||
| pgMajorVersion := strings.Split(os.Getenv("POSTGRES_VERSION"), ".")[0] | |||
| version, _ := strconv.Atoi(pgMajorVersion) | |||
There was a problem hiding this comment.
POSTGRES_VERSION is set to latest as part of the CI test matrix, ie not necessarily a Major.Minor string.
It's really a Postgres docker image tag, not strictly a postgres version number.
Maybe put this logic in a function and handle the case where it isn't Major.Minor release number.
andrew-farries
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
foreign_keyconstraints in table constraint definitions increate_table.It includes all settings that are currently available in PostgreSQL 17. At the moment, this option is superior to other foreign key definitions in pgroll because it supports
ON UPDATEandMATCHtype settings. As I mentioned in earlier PRs, once this work is finished, I am unifying the constraint options in all operations.Example constraint configuration:
{ "name": "provider_fk", "type": "foreign_key", "columns": [ "provider_id", "product_id" ], "deferrable": false, "references": { "table": "provider", "columns": [ "id", "product_id" ], "on_delete": "SET DEFAULT", "on_delete_set_columns": ["id"], "on_update": "CASCADE", "match_type": "SIMPLE" } }