Add android example app #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muteeburrehman
force-pushed
the
android-example
branch
from
eb2cb96 to
26393da
Compare
muzzammilshahid
requested changes
May 27, 2024
android-example/build.gradle
Outdated
| implementation 'androidx.activity:activity:1.9.0' | ||
|
|
||
| implementation 'io.xconn:cryptology:1.1.2' |
There was a problem hiding this comment.
Suggested change
| implementation 'io.xconn:cryptology:1.1.2' | |
| implementation project(path: ':cryptology') |
| @@ -0,0 +1,27 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
| xmlns:app="http://schemas.android.com/apk/res-auto" | |||
There was a problem hiding this comment.
Suggested change
| xmlns:app="http://schemas.android.com/apk/res-auto" |
| android:id="@+id/enterPassword" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginLeft="30dp" |
There was a problem hiding this comment.
Suggested change
| android:layout_marginLeft="30dp" |
Comment on lines
6
to
7
| <!-- TODO: Remove or change this placeholder text --> | ||
| <string name="hello_blank_fragment">Hello blank fragment</string> |
There was a problem hiding this comment.
Suggested change
| <!-- TODO: Remove or change this placeholder text --> | |
| <string name="hello_blank_fragment">Hello blank fragment</string> |
Comment on lines
13
to
14
| <string name="password1">Password:</string> | ||
| <string name="enter_password1">Enter password...</string> |
There was a problem hiding this comment.
use already defined strings
| <string name="select_photo">Select Photo</string> | ||
| <string name="capture">Capture</string> | ||
| <string name="password">Password:</string> | ||
| <string name="enter_password">Enter password...</string> |
There was a problem hiding this comment.
Suggested change
| <string name="enter_password">Enter password...</string> | |
| <string name="enter_password">Enter password…</string> |
| assert bitmap != null; | ||
| byte[] imageData = bitmapToByteArray(bitmap); | ||
|
|
||
| byte[] publicKey = hexToBytes(App.getString("public_key")); |
There was a problem hiding this comment.
Suggested change
| byte[] publicKey = hexToBytes(App.getString("public_key")); | |
| byte[] publicKey = hexToBytes(App.getString(App.PREF_PUBLIC_KEY)); |
muzzammilshahid
requested changes
May 27, 2024
Comment on lines
91
to
102
| private void dispatchTakePictureIntent() { | ||
| if (ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.CAMERA) | ||
| != PackageManager.PERMISSION_GRANTED) { | ||
| requestCameraPermission(); | ||
| } else { | ||
| startCamera(); | ||
| } | ||
| } | ||
|
|
||
| private void requestCameraPermission() { | ||
| cameraPermissionLauncher.launch(Manifest.permission.CAMERA); | ||
| } |
There was a problem hiding this comment.
Suggested change
| private void dispatchTakePictureIntent() { | |
| if (ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.CAMERA) | |
| != PackageManager.PERMISSION_GRANTED) { | |
| requestCameraPermission(); | |
| } else { | |
| startCamera(); | |
| } | |
| } | |
| private void requestCameraPermission() { | |
| cameraPermissionLauncher.launch(Manifest.permission.CAMERA); | |
| } | |
| private void dispatchTakePictureIntent() { | |
| if (ContextCompat.checkSelfPermission(requireContext(), Manifest.permission.CAMERA) | |
| != PackageManager.PERMISSION_GRANTED) { | |
| requestCameraPermission(); | |
| } else { | |
| cameraPermissionLauncher.launch(Manifest.permission.CAMERA); | |
| } | |
| } |
muzzammilshahid
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #26