🎈 perf: the logic for highlighting

xiangechen · Dec 28, 2023 · c3e03d5 · c3e03d5
1 parent a8c1bb9
commit c3e03d5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/packages/chili-vis/src/modelSelectionEventHandler.ts b/packages/chili-vis/src/modelSelectionEventHandler.ts
@@ -49,7 +49,5 @@ export class ModelSelectionHandler extends SelectionHandler {
         return this._models.size;
     }
 
-    override clearSelected(document: IDocument): void {
-        document.selection.clearSelected();
-    }
+    override clearSelected(document: IDocument): void {}
 }
diff --git a/packages/chili/src/commands/create/createCommand.ts b/packages/chili/src/commands/create/createCommand.ts
@@ -13,6 +13,11 @@ export abstract class CreateCommand extends MultistepCommand {
     }
 
     protected abstract create(): GeometryModel;
+
+    protected override beforeExecute(): Promise<boolean> {
+        this.document.selection.clearSelected();
+        return super.beforeExecute();
+    }
 }
 
 export abstract class CreateFaceableCommand extends CreateCommand {

diff --git a/packages/chili/src/step/step.ts b/packages/chili/src/step/step.ts
@@ -19,7 +19,6 @@ export abstract class StepBase<D extends ValidatorData> implements IStep {
     ) {}
 
     async execute(document: IDocument, controller: AsyncController): Promise<SnapedData | undefined> {
-        document.selection.clearSelected();
         let data = this.handleData();
         if (data.validators === undefined) data.validators = [];
         data.validators.push((point) => this.validator(data, point));