Merge pull request #37 from xin9le/feature/omit-ROS-byte

Remove unnecessary `ReadOnlySpan<byte>` overloads
xin9le · Sep 5, 2024 · b479f40 · b479f40
2 parents fab5b23 + e39c6d4
commit b479f40
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 126 deletions.
diff --git a/src/libs/FastEnum.Core/Internals/UnderlyingOperation.cs b/src/libs/FastEnum.Core/Internals/UnderlyingOperation.cs
@@ -1,4 +1,4 @@
-// <auto-generated>
+// <auto-generated>
 // This .cs file is generated by T4 template. Don't change it. Change the .tt file instead.
 // </auto-generated>
 #nullable enable
@@ -117,34 +117,6 @@ public static bool TryParseValue(ReadOnlySpan<char> text, out T result)
     }
 
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-    {
-        switch (EnumInfo<T>.s_typeCode)
-        {
-            case TypeCode.SByte:
-                return SByteOperation.TryParseValue(text, out result);
-            case TypeCode.Byte:
-                return ByteOperation.TryParseValue(text, out result);
-            case TypeCode.Int16:
-                return Int16Operation.TryParseValue(text, out result);
-            case TypeCode.UInt16:
-                return UInt16Operation.TryParseValue(text, out result);
-            case TypeCode.Int32:
-                return Int32Operation.TryParseValue(text, out result);
-            case TypeCode.UInt32:
-                return UInt32Operation.TryParseValue(text, out result);
-            case TypeCode.Int64:
-                return Int64Operation.TryParseValue(text, out result);
-            case TypeCode.UInt64:
-                return UInt64Operation.TryParseValue(text, out result);
-            default:
-                result = default;
-                return false;
-        }
-    }
-
-
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
     {
@@ -232,15 +204,6 @@ public static bool TryParseValue(ReadOnlySpan<char> text, out T result)
         }
 
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-        {
-            Unsafe.SkipInit(out result);
-            ref var x = ref Unsafe.As<T, sbyte>(ref result);
-            return sbyte.TryParse(text, CultureInfo.InvariantCulture, out x);
-        }
-
-
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
         {
@@ -338,15 +301,6 @@ public static bool TryParseValue(ReadOnlySpan<char> text, out T result)
         }
 
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-        {
-            Unsafe.SkipInit(out result);
-            ref var x = ref Unsafe.As<T, byte>(ref result);
-            return byte.TryParse(text, CultureInfo.InvariantCulture, out x);
-        }
-
-
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
         {
@@ -444,15 +398,6 @@ public static bool TryParseValue(ReadOnlySpan<char> text, out T result)
         }
 
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-        {
-            Unsafe.SkipInit(out result);
-            ref var x = ref Unsafe.As<T, short>(ref result);
-            return short.TryParse(text, CultureInfo.InvariantCulture, out x);
-        }
-
-
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
         {
@@ -550,15 +495,6 @@ public static bool TryParseValue(ReadOnlySpan<char> text, out T result)
         }
 
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-        {
-            Unsafe.SkipInit(out result);
-            ref var x = ref Unsafe.As<T, ushort>(ref result);
-            return ushort.TryParse(text, CultureInfo.InvariantCulture, out x);
-        }
-
-
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
         {
@@ -656,15 +592,6 @@ public static bool TryParseValue(ReadOnlySpan<char> text, out T result)
         }
 
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-        {
-            Unsafe.SkipInit(out result);
-            ref var x = ref Unsafe.As<T, int>(ref result);
-            return int.TryParse(text, CultureInfo.InvariantCulture, out x);
-        }
-
-
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
         {
@@ -762,15 +689,6 @@ public static bool TryParseValue(ReadOnlySpan<char> text, out T result)
         }
 
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-        {
-            Unsafe.SkipInit(out result);
-            ref var x = ref Unsafe.As<T, uint>(ref result);
-            return uint.TryParse(text, CultureInfo.InvariantCulture, out x);
-        }
-
-
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
         {
@@ -868,15 +786,6 @@ public static bool TryParseValue(ReadOnlySpan<char> text, out T result)
         }
 
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-        {
-            Unsafe.SkipInit(out result);
-            ref var x = ref Unsafe.As<T, long>(ref result);
-            return long.TryParse(text, CultureInfo.InvariantCulture, out x);
-        }
-
-
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
         {
@@ -974,15 +883,6 @@ public static bool TryParseValue(ReadOnlySpan<char> text, out T result)
         }
 
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-        {
-            Unsafe.SkipInit(out result);
-            ref var x = ref Unsafe.As<T, ulong>(ref result);
-            return ulong.TryParse(text, CultureInfo.InvariantCulture, out x);
-        }
-
-
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
         {

diff --git a/src/libs/FastEnum.Core/Internals/UnderlyingOperation.tt b/src/libs/FastEnum.Core/Internals/UnderlyingOperation.tt
@@ -94,22 +94,6 @@ internal static class UnderlyingOperation<T>
     }
 
 
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-    {
-        switch (EnumInfo<T>.s_typeCode)
-        {
-<# foreach (var x in parameters) { #>
-            case TypeCode.<#= x.TypeName #>:
-                return <#= x.TypeName #>Operation.TryParseValue(text, out result);
-<# } #>
-            default:
-                result = default;
-                return false;
-        }
-    }
-
-
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
     {
@@ -186,15 +170,6 @@ internal static class UnderlyingOperation<T>
         }
 
 
-        [MethodImpl(MethodImplOptions.AggressiveInlining)]
-        public static bool TryParseValue(ReadOnlySpan<byte> text, out T result)
-        {
-            Unsafe.SkipInit(out result);
-            ref var x = ref Unsafe.As<T, <#= x.CompatibleName #>>(ref result);
-            return <#= x.CompatibleName #>.TryParse(text, CultureInfo.InvariantCulture, out x);
-        }
-
-
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static bool TryGetMember(T value, [NotNullWhen(true)] out Member<T>? result)
         {