Unify register assignment in NEON assembly for get_sad #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like something isn't quite happy here: https://travis-ci.org/github/xiph/rav1e/builds/748500930 |
barrbrain
force-pushed
the
aarch64-sad
branch
from
b5cad8a to
baaa9ef
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2607 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 87 87
Lines 28221 28221
=======================================
Hits 24898 24898
Misses 3323 3323 ☔ View full report in Codecov by Sentry. |
barrbrain
force-pushed
the
aarch64-sad
branch
3 times, most recently
from
bf3d919 to
bd233ee
Compare
Easier to read and reduces compressed compiled object size by 10%.
barrbrain
force-pushed
the
aarch64-sad
branch
from
bd233ee to
60dd8a8
Compare
lu-zero
approved these changes
Dec 4, 2023
For sure, most of the wider distortion kernels. I will revisit them when we have a complete set of distortion assembly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier to read and reduces compressed compiled object size by 10%.