-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devcontainer: Update and add support for arm64 hosts #3282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3282 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 87 87
Lines 28221 28221
=======================================
Hits 24898 24898
Misses 3323 3323 ☔ View full report in Codecov by Sentry. |
barrbrain
force-pushed
the
devcontainer-prebuilt
branch
from
November 17, 2023 01:50
b4b80f8
to
4f05f59
Compare
barrbrain
commented
Nov 21, 2023
barrbrain
force-pushed
the
devcontainer-prebuilt
branch
2 times, most recently
from
November 23, 2023 06:19
7d8546a
to
e0ae71f
Compare
barrbrain
force-pushed
the
devcontainer-prebuilt
branch
2 times, most recently
from
November 30, 2023 17:27
f45a9a0
to
0f6a5dd
Compare
I verified the muilt-arch manifest on my fork: docker manifest inspect ghcr.io/barrbrain/rav1e-devcontainer:latest {
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"manifests": [
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 3906,
"digest": "sha256:b6a67286b6299678c40e9e6abd029dbac8da2382cb10c7e04c984532ae1dfa0b",
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 3694,
"digest": "sha256:f6e81cc7caadfff3e121c70daf70c48cddb72efa977873600d29237385dd6bfe",
"platform": {
"architecture": "arm64",
"os": "linux"
}
}
]
} |
We could save a lot of build time by cross-compiling the cargo tools:
|
barrbrain
force-pushed
the
devcontainer-prebuilt
branch
3 times, most recently
from
December 1, 2023 15:15
d3c2f5b
to
f2f1782
Compare
barrbrain
changed the title
devcontainer: Explicitly bump the base image revision
devcontainer: Update and add support for arm64 hosts
Dec 4, 2023
Update Intel SDE to 9.27.0 and explicitly version all included tools. This will trigger an image rebuild when a new toolchain is released.
barrbrain
force-pushed
the
devcontainer-prebuilt
branch
from
December 5, 2023 10:15
f2f1782
to
9f4038c
Compare
lu-zero
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will facilitate rebuild when a new Rust toolchain is released. We should sync with
cargo-c
releases.Added support for
linux/arm64
hosts to the prebuilt image.