X.H.EwmhDesktops: Avoid some unnecessary refreshes #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second commit makes it possible to add non-flicker focusNth keybindings. As GitHub doesn't really support dependent pull requests, I'm just putting it here. @byorgey Are we doing the "two pairs of eyes" reviews in between committers or am I supposed to just commit trivial stuff like this to master? |
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Adopt XMonad.Util.PureX to avoid refreshing unless something actually changes.
liskin
force-pushed
the
ewmh-flicker
branch
from
d405eb3 to
cb7d025
Compare
4 tasks
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
Nov 5, 2020
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
|
Replaced by a commit in #399, closing. |
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
Nov 6, 2020
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
Nov 15, 2020
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
Nov 16, 2020
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
Jan 25, 2021
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
Jan 30, 2021
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
Feb 7, 2021
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
liskin
added a commit
to liskin/xmonad-contrib
that referenced
this pull request
Mar 23, 2021
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
TheMC47
pushed a commit
to TheMC47/xmonad-contrib
that referenced
this pull request
Apr 7, 2021
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
TheMC47
pushed a commit
to TheMC47/xmonad-contrib
that referenced
this pull request
Apr 13, 2021
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
TheMC47
pushed a commit
to TheMC47/xmonad-contrib
that referenced
this pull request
May 21, 2021
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change. Related: xmonad#371
liskin
added a commit
that referenced
this pull request
May 21, 2021
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change to get rid of the annoying border flicker that is inevitable with the current implementation of XMonad.Operations.windows. (Note that Steam also sends ConfigureRequest events, and these cause an additional refresh due to the call to `float` when handling the event in xmonad core. Not sure if worth fixing.) Related: #371 Related: #399
TheMC47
pushed a commit
to TheMC47/xmonad-contrib
that referenced
this pull request
May 31, 2021
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for every mouse click which results in a lot of border blinking. Ignore requests that would result in no change to get rid of the annoying border flicker that is inevitable with the current implementation of XMonad.Operations.windows. (Note that Steam also sends ConfigureRequest events, and these cause an additional refresh due to the call to `float` when handling the event in xmonad core. Not sure if worth fixing.) Related: xmonad#371 Related: xmonad#399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current version of Steam sends _NET_ACTIVE_WINDOW ClientMessage for
every mouse click which results in a lot of border blinking. Adopt
XMonad.Util.PureX to avoid refreshing unless something actually changes.
Checklist
I've read CONTRIBUTING.md
I tested my changes with xmonad-testing
I updated the
CHANGES.mdfileI updated the
XMonad.Doc.Extendingfile (if appropriate)