Make pool read-only, with a single write connection. #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codabrink
force-pushed
the
coda/write-flag
branch
from
23c6bb6 to
b5205c1
Compare
insipx
reviewed
Jan 16, 2025
insipx
reviewed
Jan 16, 2025
codabrink
force-pushed
the
coda/write-flag
branch
from
7d2c128 to
0282c31
Compare
codabrink
force-pushed
the
coda/write-flag
branch
3 times, most recently
from
c5ed9b2 to
d547dc8
Compare
codabrink
force-pushed
the
coda/write-flag
branch
from
d547dc8 to
d3fa5b9
Compare
codabrink
force-pushed
the
coda/write-flag
branch
from
ce36687 to
a4a521c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
insipx
requested changes
Feb 3, 2025
codabrink
force-pushed
the
coda/write-flag
branch
from
14e2d4b to
39230c7
Compare
codabrink
commented
Feb 3, 2025
| // wasm does not have threads | ||
| #[cfg_attr(not(target_arch = "wasm32"), tokio::test)] | ||
| #[cfg(not(target_arch = "wasm32"))] | ||
| async fn test_transaction_rollback() { |
There was a problem hiding this comment.
Deleted this test since the barriers in this test were trying to force something that should be impossible now and was causing a deadlock.
There was a problem hiding this comment.
right, because the barriers would never progress since the transaction never finishes. So we would only deadlock IRL if we somehow had a transaction that never finishes or infinity-loops, which shouldn't happen w/o async or a bug
insipx
reviewed
Feb 3, 2025
mchenani
approved these changes
Feb 3, 2025
insipx
reviewed
Feb 3, 2025
insipx
reviewed
Feb 3, 2025
|
|
||
| let conn = self.conn_ref(); | ||
| let _guard = conn.start_transaction::<Db>()?; |
There was a problem hiding this comment.
now that async transactions are gone and our connection is a mutex, can we use diesels transaction function?
insipx
reviewed
Feb 3, 2025
insipx
approved these changes
Feb 3, 2025
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.