-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Fix socket channel config bug #100
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
- Coverage 88.97% 85.09% -3.89%
==========================================
Files 48 54 +6
Lines 4038 4556 +518
Branches 770 833 +63
==========================================
+ Hits 3593 3877 +284
- Misses 358 586 +228
- Partials 87 93 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In the last PR, we added a
parse_config
method in socket channel. This method is mainly for extractinglisten_elastic_ip
inextra_conf
.However, when xorbits calls it, this
config
contains keyword arguments likeucx
inextra_conf
.The config will further affect the following code as
asyncio.start_server
does not have theucx
keyword argument.In xorbits, this config contains stuff about ucx like:
{'ucx': {'tcp': None, 'nvlink': None, 'infiniband': None, 'rdmacm': None, 'cuda-copy': None, 'create-cuda-contex': None}}
. This config is frompython/xorbits/_mars/deploy/oscar/base_config.yml
.However, SocketChannel does not use the ucx config. So we do not need it here.
Check code requirements