-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix leaking clients in actor caller #115
BUG: Fix leaking clients in actor caller #115
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 88.97% 84.76% -4.22%
==========================================
Files 48 53 +5
Lines 4038 4626 +588
Branches 770 503 -267
==========================================
+ Hits 3593 3921 +328
- Misses 358 603 +245
- Partials 87 102 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Background: If an actor is called from a thread and the thread exits after the call, the client will leak in the actor caller, and the corresponding channel will still be open.
This PR auto close the actor callers and channels that belongs to the exited thread.
What do these changes do?
Related issue number
Fixes #xxxx
Check code requirements