Use a temporary file to prevent cache file corruption when interrupted. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SonarBeserk
added a commit
to SonarBeserk/humblebundle-downloader
that referenced
this pull request
Nov 3, 2022
SonarBeserk
added a commit
to SonarBeserk/humblebundle-downloader
that referenced
this pull request
Nov 3, 2022
…nt corruption" This reverts commit 259dbde.
sparr
reviewed
Jul 27, 2024
| @@ -59,6 +59,7 @@ def __init__(self, library_path, cookie_path=None, cookie_auth=None, | |||
| def start(self): | |||
|
|
|||
| self.cache_file = os.path.join(self.library_path, '.cache.json') | |||
| self.cache_file_temp = os.path.join(self.library_path, '.tmp.cache.json') | |||
There was a problem hiding this comment.
Suggested change
| self.cache_file_temp = os.path.join(self.library_path, '.tmp.cache.json') | |
| self.cache_file_temp = os.path.join(self.library_path, '.cache.json.tmp') |
sparr
reviewed
Jul 28, 2024
| json.dump( | ||
| self.cache_data, outfile, | ||
| sort_keys=True, indent=4, | ||
| ) | ||
| outfile.close() #explicitly close outfile and flush output buffer. | ||
| os.rename(self.cache_file_temp,self.cache_file) #rename temp file to real file. |
There was a problem hiding this comment.
rename should fail if the destination file already exists. I think you need to rename the old file, rename the new file, then delete the old file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a few times where my .cache.json file was corrupted because I hit Ctrl-C during a download. This should prevent that.