fix utcnow() deprecation warning #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitek
requested changes
Feb 14, 2024
tests/plugins/test_mocked_time.py
Outdated
| @@ -21,7 +21,9 @@ def test_disabled_mocked_time_raises_on_usage_attempt(mocked_time): | |||
| assert not mocked_time.is_enabled | |||
|
|
|||
| with pytest.raises(mocked_time_module.DisabledUsageError): | |||
| mocked_time.set(datetime.datetime.utcnow()) | |||
| mocked_time.set( | |||
| datetime.datetime.now(datetime.timezone.utc).replace(tzinfo=None) | |||
There was a problem hiding this comment.
как будто мы тут должны поддержать tz-aware даты, просто внутри переводить в utc и выкидывать часть с таймзоной
testsuite/mockserver/server.py
Outdated
| @@ -281,7 +281,9 @@ def _log_request(self, started, request, response=None, exc=None): | |||
| return | |||
| fields = { | |||
| '_type': 'mockserver_request', | |||
| 'timestamp': datetime.datetime.utcnow(), | |||
| 'timestamp': datetime.datetime.now(datetime.timezone.utc).replace( | |||
There was a problem hiding this comment.
возможно для этого лучше завести функцию где-то в utils
docs/other_plugins.rst
Outdated
| @@ -54,7 +54,7 @@ used in a particular test: ``@pytest.mark.now('2016-12-01T12:00:00')`` or | |||
| ``@pytest.mark.now(enabled=True)``. | |||
|
|
|||
| If time is not specified in ``@pytest.mark.now``, then | |||
| ``datetime.datetime.utcnow()`` value at the start of test is used as time value | |||
| ``datetime.datetime.now(datetime.timezone.utc).replace(tzinfo=None)`` value at the start of test is used as time value | |||
There was a problem hiding this comment.
лучше написать, что будет использовано текущее время в utc
vitek
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace datetime.utcnow() withdatetime.now(datetime.timezone.utc).replace(tzinfo=None)