Merge pull request #96 from yanlesin/Q42024_file

Q4 2024 file tested
yanlesin · Jan 17, 2025 · c5d6c77 · c5d6c77
2 parents 6881941 + 35b2b26
commit c5d6c77
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: SEC13Flist
 Title: Functions to Work with Official List of SEC Section 13(f) Securities and Security Identifiers
-Version: 1.1.0
+Version: 1.1.1
 Authors@R: 
     person(given = "Yan",
            family = "Lyesin",

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # SEC13Flist 
 
+## 1.1.1
+
+* updated tests to reflect content of Q4 files for 2024
+
 ## 1.1.0
 
 * significant change: `SEC_13F_list` function no longer attempts to determine current year and quarter for the official list - it will produce an error when no year and quarter supplied to the function call

diff --git a/tests/testthat/test-SEC_row_count.R b/tests/testthat/test-SEC_row_count.R
@@ -1,7 +1,7 @@
 test_that("Parsed row count equal to total row count per PDF list", {
   options(HTTPUserAgent="Yan Lyesin, SEC13Flist Package for R, [email protected] ")
   YEAR_ <- 2024
-  QUARTER_ <- 3
+  QUARTER_ <- 4
 
     file_name <- paste0('13flist', YEAR_, 'q', QUARTER_, '.pdf')
     url_file <-

diff --git a/tests/testthat/test-has_listed_options.R b/tests/testthat/test-has_listed_options.R
@@ -1,6 +1,6 @@
 test_that("list of possible values for HAS_LISTED_OPTION column", {
   options(HTTPUserAgent="Yan Lyesin, SEC13Flist Package for R, [email protected] ")
-  list_all <- SEC13Flist::SEC_13F_list(2023, 3)
+  list_all <- SEC13Flist::SEC_13F_list(2024, 4)
   list_all <- unique(list_all["HAS_LISTED_OPTION"])
   list_HAS_LISTED_OPTION <- nrow(subset(list_all, !HAS_LISTED_OPTION %in% c("","*")))
   expect_equal(list_HAS_LISTED_OPTION, 0)

diff --git a/tests/testthat/test-status.R b/tests/testthat/test-status.R
@@ -3,7 +3,7 @@ test_that("list of possible values for STATUS column", {
   STATUS_1 <- ""
   STATUS_2 <- "ADDED"
   STATUS_3 <- "DELETED"
-  list_all <- SEC13Flist::SEC_13F_list(2024, 3)
+  list_all <- SEC13Flist::SEC_13F_list(2024, 4)
   list_all <- unique(list_all["STATUS"])
   list_STATUS <- nrow(subset(list_all, !STATUS %in% c(STATUS_1,STATUS_2,STATUS_3)))
   expect_equal(list_STATUS, 0)