Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4369: Include pull requests in git ref search #4411

Merged
merged 2 commits into from
Sep 12, 2017
Merged

Fix #4369: Include pull requests in git ref search #4411

merged 2 commits into from
Sep 12, 2017

Conversation

kaylie-alexa
Copy link
Member

@kaylie-alexa kaylie-alexa commented Sep 12, 2017 •
edited by BYK
Loading

Summary

Fixes #4369, a regression from previous refactor.
Include pull requests in ref search and test for it later when it's called by github resolver.

BEFORE
before

AFTER
after

Test plan

Added a unit test in git/git-ref-resolver.js

@buildsize
Copy link

buildsize bot commented Sep 12, 2017

This change will increase the build size from 9.51 MB to 9.51 MB, an increase of 441 bytes (0%)

File name Previous Size New Size Change
yarn-[version].noarch.rpm 819.59 KB 819.55 KB -37 bytes (0%)
yarn-[version].js 3.62 MB 3.62 MB 217 bytes (0%)
yarn-legacy-[version].js 3.67 MB 3.67 MB 217 bytes (0%)
yarn-v[version].tar.gz 823.72 KB 823.72 KB 2 bytes (0%)
yarn_[version]all.deb 626.32 KB 626.36 KB 42 bytes (0%)

1 similar comment
@buildsize
Copy link

buildsize bot commented Sep 12, 2017

This change will increase the build size from 9.51 MB to 9.51 MB, an increase of 441 bytes (0%)

File name Previous Size New Size Change
yarn-[version].noarch.rpm 819.59 KB 819.55 KB -37 bytes (0%)
yarn-[version].js 3.62 MB 3.62 MB 217 bytes (0%)
yarn-legacy-[version].js 3.67 MB 3.67 MB 217 bytes (0%)
yarn-v[version].tar.gz 823.72 KB 823.72 KB 2 bytes (0%)
yarn_[version]all.deb 626.32 KB 626.36 KB 42 bytes (0%)

BYK
BYK approved these changes Sep 12, 2017
View reviewed changes
Copy link
Member

@BYK BYK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@BYK BYK merged commit 4e3ecf8 into yarnpkg:master Sep 12, 2017
@arcanis
Copy link
Member

arcanis commented Sep 12, 2017 •
edited
Loading

FYI I don't think this was a regression but rather a non-feature - cf #3012 which was implementing it, but that we closed (rational at the time was that if people want to use PR branches as a package source, then they should reference the source repository rather than the target repository).

@BYK BYK mentioned this pull request Sep 12, 2017
Closed
@BYK BYK added this to the 1.0.2 milestone Sep 12, 2017
joaolucasl pushed a commit to joaolucasl/yarn that referenced this pull request Oct 27, 2017
@joaolucasl
Fix: Include pull requests in git ref search (yarnpkg#4411)
1fef7fd 
**Summary**

Fixes yarnpkg#4369, a regression from previous refactor.
Include `pull` requests in ref search and test for it later when it's called by github resolver.

*BEFORE*
![before](https://user-images.githubusercontent.com/18429494/30309691-7aeabe2e-9741-11e7-8e34-c75413b83d99.png)


*AFTER*
![after](https://user-images.githubusercontent.com/18429494/30309693-7dcc3528-9741-11e7-8a74-bc7585fd6177.png)

**Test plan**

Added a unit test in `git/git-ref-resolver.js`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BYK BYK BYK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

Yarn 1.X - Can't install Github Pull Requests anymore
3 participants
@kaylie-alexa @arcanis @BYK