New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#90: refactored collection index to not use Should(Have.Count(...) #103

Merged

yashaka merged 1 commit into yashaka:master from wjgerritsen-0001:refactor_collection_index_without_should

Nov 5, 2024

Contributor

wjgerritsen-0001 commented Sep 13, 2024

Refactor the index method in the Collection. Now it will only timeout in case of real failure, see added testcase.

Not fully sure about the error message, see below:

Timed out after 0,25s, while waiting for:
    Browser.All(#will-not-appear)[100].Should(Be.InDom)
Reason:
    element was not found in collection by index 100 (actual collection size is 0)


          yashaka#90: refactored collection index to not use Should(Have.Count(…

6d3b831

…...)

Owner

yashaka commented Sep 13, 2024

Will try to review it this weekend! thank you for the PR!

yashaka merged commit b53fd80 into yashaka:master

1 check failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet